fix(autoware_utils_uuid): include cstdint as uint8_t is used #79
Conversation
traversaro
requested review from
JianKangEgon,
esteve,
isamu-takagi,
mitsudome-r and
youtalk
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
|
xref: RoboStack/ros-humble#320 |
There was a problem hiding this comment.
@traversaro thanks! We check DCO for every commit (like ROS does), could you amend your commit so that it includes your signature? Thanks.
Sure! Just FYI I am not sure you are aware that DCO can be required at the GitHub level (see https://docs.github.com/en/organizations/managing-organization-settings/managing-the-commit-signoff-policy-for-your-organization or https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-the-commit-signoff-policy-for-your-repository), that has the advantage that web ui commits automatically have Signed-off . If I recall correctly, that setting is enabled in both ros2 and gazebosim organizations. |
Signed-off-by: Silvio <[email protected]>
wep21
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
======================================
Coverage ? 0.95%
======================================
Files ? 76
Lines ? 3445
Branches ? 361
======================================
Hits ? 33
Misses ? 3407
Partials ? 5
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@traversaro I didn't know about that, that's really cool, thanks! |
3 participants
Description
As
uuid_helper.hppusesuint8_ttype, it should include thecstdintheader, see https://en.cppreference.com/w/cpp/types/integer.html .How was this PR tested?
By compiling the project.
Notes for reviewers
None.
Effects on system behavior
None.